Added nd_service.py and nd_service_instance.py modules to manage ND services #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sajagana
requested review from
lhercot,
shrsr,
akinross,
anvitha-jain and
gmicol
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #53 +/- ##
==========================================
+ Coverage 34.40% 37.49% +3.09%
==========================================
Files 24 28 +4
Lines 1994 2163 +169
Branches 433 468 +35
==========================================
+ Hits 686 811 +125
- Misses 1271 1295 +24
- Partials 37 57 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
sajagana
force-pushed
the
20_nd_app_lifecycle
branch
2 times, most recently
from
de371ef to
8f3cb4e
Compare
akinross
requested changes
Sep 26, 2023
sajagana
force-pushed
the
20_nd_app_lifecycle
branch
from
1f80f99 to
dfb3a6d
Compare
sajagana
force-pushed
the
20_nd_app_lifecycle
branch
from
ba4fb93 to
c403eed
Compare
akinross
requested changes
Sep 29, 2023
gmicol
approved these changes
Oct 12, 2023
shrsr
requested changes
Oct 16, 2023
sajagana
force-pushed
the
20_nd_app_lifecycle
branch
from
15919b2 to
6a48e14
Compare
gmicol
approved these changes
Oct 25, 2023
… to manage ND services
…e and nd_service_instance modules and added additional validation checks to nd_service_instance module delete state
…_instance modules
…c in the nd_service module
lhercot
force-pushed
the
20_nd_app_lifecycle
branch
from
6a48e14 to
b257ba4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note:
Local service package import is not supported and the module supported on ND version 2.3+